Use some more C# 8.0 features for async Ix #904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't yet put
[EnumeratorCancellation]
onCancellationToken
parameters in local functions, because those don't support attributes (see dotnet/csharplang#794). We can figure out which direction to go for those; either motivate getting custom attributes on local functions (because async iterators implementations as local functions seems a common case), or move these back to top-level methods just to support using the attribute (and do away with theCreate(Core)
dance in theIAsyncEnumerator<T>
space).